Burnwire #12
Merged
Burnwire #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-core-reference into burnwire
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a new burnwire component to the F´ reference deployment for controlling burn wire hardware, along with associated GPIO pins and safety features.
- Adds burnwire component with GPIO control, safety timer, and command/port interfaces
- Updates hardware configuration to support two new GPIO pins for burnwire control
- Includes documentation, integration tests, and topology integration
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| settings.ini | Updates board configuration to v5d |
| boards/bronco_space/proves_flight_control_board_v5/proves_flight_control_board_v5.dtsi | Adds GPIO pin definitions for two burnwire pins |
| README.md | Adds comprehensive documentation for adding components (with merge conflict) |
| Makefile | Adds blank lines |
| FprimeZephyrReference/test/int/burnwire_test.py | Adds integration tests for burnwire functionality |
| FprimeZephyrReference/ReferenceDeployment/Top/topology.fpp | Adds burnwire instances and connections to topology |
| FprimeZephyrReference/ReferenceDeployment/Top/instances.fpp | Adds burnwire component instances with base IDs |
| FprimeZephyrReference/ReferenceDeployment/Top/ReferenceDeploymentTopology.cpp | Adds GPIO device tree configuration for burnwire pins |
| FprimeZephyrReference/ReferenceDeployment/Main.cpp | Adds debug print statements |
| FprimeZephyrReference/Components/ImuManager/ImuManager.cpp | Adds debug print statement |
| FprimeZephyrReference/Components/Drv/RtcManager/RtcManager.cpp | Adds debug print statement |
| FprimeZephyrReference/Components/CMakeLists.txt | Adds burnwire component to build |
| FprimeZephyrReference/Components/Burnwire/docs/sdd.md | Adds component documentation |
| FprimeZephyrReference/Components/Burnwire/CMakeLists.txt | Adds burnwire component build configuration |
| FprimeZephyrReference/Components/Burnwire/Burnwire.hpp | Adds burnwire component header file |
| FprimeZephyrReference/Components/Burnwire/Burnwire.fpp | Adds burnwire component F´ definition |
| FprimeZephyrReference/Components/Burnwire/Burnwire.cpp | Adds burnwire component implementation |
| FprimeZephyrReference/Components/BootloaderTrigger/BootloaderTrigger.cpp | Adds debug print statement |
Comments suppressed due to low confidence (1)
FprimeZephyrReference/Components/Burnwire/Burnwire.hpp:1
- Corrected spelling of 'mabger' to 'manager'.
// ======================================================================
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
FprimeZephyrReference/ReferenceDeployment/Top/ReferenceDeploymentTopology.cpp
Outdated
Show resolved
Hide resolved
…-core-reference into burnwire
Contributor
Author
|
Turns out that the burnwire test sends its first command before the gds actually starts. While sleeping and other asserts doesn't seem to help much, moving it to be after a test that doesnt send commands (ie imu_manager tests) allows to it succead properlly on the runner. More experimentation should be done to properly understand this issue |
hrfarmer
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds Burnwire component into the topology
How has this been tested?
Checklist